]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Kill intel_crtc->cursor_bo
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 14 Dec 2015 15:35:02 +0000 (17:35 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 22 Dec 2015 10:59:06 +0000 (12:59 +0200)
commit6fbe59a31d60ce9dd390d0a560b8c2c0ee38ff71
tree892aefe2ba755b0a838b0f32518dffe12712b1c3
parent094d9dbf7130a4b1452f1d0d45b05fe688d6262d
drm/i915: Kill intel_crtc->cursor_bo

The vma may have been rebound between the last time the cursor was
enabled and now, so skipping the cursor gtt offset deduction is not
safe unless we would also reset cursor_bo to NULL when disabling the
cursor. Just thow cursor_bo to the bin instead since it's lost all
other uses thanks to universal plane support.

Chris pointed out that cursor updates are currently too slow
via universal planes that micro optimizations like these wouldn't
even help.

v2: Add a note about futility of micro optimizations (Chris)

Cc: drm-intel-fixes@lists.freedesktop.org
References: http://lists.freedesktop.org/archives/intel-gfx/2015-December/082976.html
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1450107302-17171-1-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
(cherry picked from commit 1264859d648c4bdc9f0a098efbff90cbf462a075)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_drv.h