]> git.baikalelectronics.ru Git - kernel.git/commit
mptcp: use untruncated hash in ADD_ADDR HMAC
authorTodd Malsbary <todd.malsbary@linux.intel.com>
Fri, 22 May 2020 02:10:49 +0000 (19:10 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 May 2020 21:21:24 +0000 (14:21 -0700)
commit6eb74bf5a9d67ddbf7ed0b5b3e9664c20269b858
tree85bd706c6bdb3bc09e76fd86271b955dd0b08743
parent130c69201209260bd625116e6f73f1548ea0952a
mptcp: use untruncated hash in ADD_ADDR HMAC

There is some ambiguity in the RFC as to whether the ADD_ADDR HMAC is
the rightmost 64 bits of the entire hash or of the leftmost 160 bits
of the hash.  The intention, as clarified with the author of the RFC,
is the entire hash.

This change returns the entire hash from
mptcp_crypto_hmac_sha (instead of only the first 160 bits), and moves
any truncation/selection operation on the hash to the caller.

Fixes: 47236da746c3 ("mptcp: use rightmost 64 bits in ADD_ADDR HMAC")
Reviewed-by: Christoph Paasch <cpaasch@apple.com>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Todd Malsbary <todd.malsbary@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/crypto.c
net/mptcp/options.c
net/mptcp/protocol.h
net/mptcp/subflow.c