]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: x_tables: don't return garbage pointer on modprobe failure
authorFlorian Westphal <fw@strlen.de>
Sat, 13 Jan 2018 13:06:08 +0000 (14:06 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 16 Jan 2018 00:51:59 +0000 (01:51 +0100)
commit6e927b5788795e7818bee5dc6368fb81ef0292b1
tree2869ff48cca83aee6deee69c1bbdc21cf5a8a2cf
parenta5c791ccf1ebc43937b5538711b86798d12bb06c
netfilter: x_tables: don't return garbage pointer on modprobe failure

request_module may return a positive error result from modprobe,
if we cast this to ERR_PTR this returns a garbage result (it passes
IS_ERR checks).

Fix it by ignoring modprobe return values entirely, just retry the
table lookup instead.

Reported-by: syzbot+980925dbfbc7f93bc2ef@syzkaller.appspotmail.com
Fixes: 79a0c6708df4 ("netfilter: xtables: add and use xt_request_find_table_lock")
Fixes: 6e0b97c490e4 ("netfilter: x_tables: unbreak module auto loading")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/x_tables.c