]> git.baikalelectronics.ru Git - kernel.git/commit
Input: i8042 - Trust firmware a bit more when probing on X86
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 9 Dec 2016 20:57:39 +0000 (12:57 -0800)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 19 Dec 2016 10:34:15 +0000 (11:34 +0100)
commit6dc4e50107ac72d31cd0360c3a65ae542ab9648b
tree49cdd9f0992b882dd0542311f04475f669168764
parentce09d391f698f81d4717435fa2703739255f482f
Input: i8042 - Trust firmware a bit more when probing on X86

The error message "Can't read CTR while initializing i8042" appears on
Cherry Trail-based devices at each boot time:

  i8042: PNP: No PS/2 controller found. Probing ports directly.
  i8042: Can't read CTR while initializing i8042
  i8042: probe of i8042 failed with error -5

This happens because we historically do not trust firmware on X86 and,
while noting that PNP does not show keyboard or mouse devices, we still
charge ahead and try to probe the controller. Let's relax this a bit and if
results of PNP probe agree with the results of platform
initialization/quirks conclude that there is, in fact, no i8042.

While at it, let's avoid using x86_platform.i8042_detect() and instead
abort execution early if platform indicates that it can not possibly have
i8042 (x86_platform.legacy.i8042 equals X86_LEGACY_I8042_PLATFORM_ABSENT).

Reported-and-tested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: linux-input@vger.kernel.org
Link: http://lkml.kernel.org/r/1481317061-31486-3-git-send-email-dmitry.torokhov@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/input/serio/i8042-x86ia64io.h