]> git.baikalelectronics.ru Git - kernel.git/commit
fbmem: fix horribly incorrect placement of __maybe_unused
authorLinus Torvalds <torvalds@linux-foundation.org>
Sun, 9 May 2021 21:03:33 +0000 (14:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 9 May 2021 21:03:33 +0000 (14:03 -0700)
commit6dae40aed484ef2f1a3934dcdcd17b7055173e56
tree00c6a6ef14a63d2d0a0a6b91ae2ba899fbd544e9
parentefc58a96adcd29cc37487a60582d9d08b34f6640
fbmem: fix horribly incorrect placement of __maybe_unused

Commit b9d79e4ca4ff ("fbmem: Mark proc_fb_seq_ops as __maybe_unused")
places the '__maybe_unused' in an entirely incorrect location between
the "struct" keyword and the structure name.

It's a wonder that gcc accepts that silently, but clang quite reasonably
warns about it:

    drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes]
    static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
                        ^

Fix it.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/fbdev/core/fbmem.c