]> git.baikalelectronics.ru Git - kernel.git/commit
ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 29 Jan 2018 23:57:48 +0000 (15:57 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 26 Feb 2018 17:11:30 +0000 (09:11 -0800)
commit6d9c92691c973a85093c7218a2e8a4d4f91310ad
tree912593d67433f3c244a08d14a9255fc9b3e6696d
parent9d622fd2007c04670e0b6825eceee83891b1ae9b
ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode

On hardware which supports timestamping all packets, the timestamps are
recorded in the packet buffer, and the driver no longer uses or reads
the registers. This makes the logic for checking and clearing Rx
timestamp hangs meaningless.

If we run the ixgbe_ptp_rx_hang() function in this case, then the driver
will continuously spam the log output with "Clearing Rx timestamp hang".
These messages are spurious, and confusing to end users.

The original code in commit 8b95512ad51a ("ixgbe: Update PTP to support
X550EM_x devices", 2015-12-03) did have a flag PTP_RX_TIMESTAMP_IN_REGISTER
which was intended to be used to avoid the Rx timestamp hang check,
however it did not actually check the flag before calling the function.

Do so now in order to stop the checks and prevent the spurious log
messages.

Fixes: 8b95512ad51a ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03)
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c