]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 6 Apr 2019 05:26:52 +0000 (08:26 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 15 Apr 2019 05:31:50 +0000 (07:31 +0200)
commit6d80e0ed9e1d250606cf284c1f491b06bca3008d
tree72c0d98f9a56f6ec1aa8d47d3ca311baa018b4f4
parent19158fa649c3a03119f2abd9d9dd4201362982b1
netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()

I believe that "hook->num" can be up to UINT_MAX.  Shifting more than
31 bits would is undefined in C but in practice it would lead to shift
wrapping.  That would lead to an array overflow in nf_tables_addchain():

ops->hook       = hook.type->hooks[ops->hooknum];

Fixes: 32ec3f9c8f25 ("netfilter: nf_tables: remove nhooks field from struct nft_af_info")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c