]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: topology: Fix a potential NULL pointer dereference in 'soc_tplg_dapm_widget_den...
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 14 Sep 2017 20:44:12 +0000 (22:44 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 14 Sep 2017 21:13:03 +0000 (14:13 -0700)
commit6d5574ed5c8b1a1f31fcbdab5d26e15533c442ca
tree84b4b6309f3c400ef5a169b0d6800ec8e04dfd8c
parentf5fd4a67bef5f2c5c2c9eb0cb2900e12d192ae23
ASoC: topology: Fix a potential NULL pointer dereference in 'soc_tplg_dapm_widget_denum_create()'

if 'se = kzalloc()' fails in the 'for' loop, we will branch to 'err'.
But in this case, 'kc[i].private_value' will still be NULL. A NULL pointer
dereference will then occur is the error handling path.

In such a case, it is safe to just 'continue' in order to skip this entry
and free the other ones.

Fixes: 1a7dd6e2f192 ("ASoC: topology: Allow a widget to have multiple enum controls")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c