]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/mm/64s: Fix preempt warning in slb_allocate_kernel()
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 1 Nov 2018 05:21:05 +0000 (16:21 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 12 Nov 2018 02:22:10 +0000 (13:22 +1100)
commit6d44ba243833c146e343e1b33c8df63fb2dceb13
tree09e7de4b0d6447d9bba8adb69f7f8b3b9b44a023
parenta9dc78eb1093e1ccf93d4519fcbea6394b499877
powerpc/mm/64s: Fix preempt warning in slb_allocate_kernel()

With preempt enabled we see warnings in do_slb_fault():

  BUG: using smp_processor_id() in preemptible [00000000] code: kworker/u33:0/98
  futex hash table entries: 4096 (order: 3, 524288 bytes)
  caller is do_slb_fault+0x204/0x230
  CPU: 5 PID: 98 Comm: kworker/u33:0 Not tainted 4.19.0-rc3-gcc-7.3.1-00022-g1936f094e164 #138
  Call Trace:
    dump_stack+0xb4/0x104 (unreliable)
    check_preemption_disabled+0x148/0x150
    do_slb_fault+0x204/0x230
    data_access_slb_common+0x138/0x180

This is caused by the get_paca() in slb_allocate_kernel(), which
includes a call to debug_smp_processor_id().

slb_allocate_kernel() can only be called from do_slb_fault(), and in
that path interrupts are hard disabled and so we can't be preempted,
but we can't update the preempt flags (in thread_info) because that
could cause an SLB fault.

So just use local_paca which is safe and doesn't cause the warning.

Fixes: e45d5ac017a5 ("powerpc/64s/hash: Convert SLB miss handlers to C")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/mm/slb.c