]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode
authorNicolas Boichat <drinkcat@chromium.org>
Mon, 18 Jan 2016 13:35:00 +0000 (21:35 +0800)
committerTakashi Iwai <tiwai@suse.de>
Mon, 18 Jan 2016 13:39:00 +0000 (14:39 +0100)
commit6c5fefc1785ab63a6273dc41c276bc4583fd05fe
tree717ac1144e8724117ea8d66896c0d36709584c46
parent40febfe084a962e7ee9448c7e25c882ef26bea13
ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode

This reverts one hunk of
commit 2a8fd2ea22be ("ALSA: sound/core: use memdup_user()"), which
replaced a number of kmalloc followed by memcpy with memdup calls.

In this case, we are copying from a struct snd_pcm_hw_params32 to
a struct snd_pcm_hw_params, but the latter is 4 bytes longer than
the 32-bit version, so we need to separate kmalloc and copy calls.

This actually leads to an out-of-bounds memory access later on
in sound/soc/soc-pcm.c:soc_pcm_hw_params() (detected using KASan).

Fixes: 2a8fd2ea22be ('ALSA: sound/core: use memdup_user()')
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_compat.c