]> git.baikalelectronics.ru Git - kernel.git/commit
ipv6: tcp: fix potential NULL deref in tcp_v6_send_reset()
authorEric Dumazet <edumazet@google.com>
Fri, 7 Jun 2019 19:23:48 +0000 (12:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Jun 2019 02:42:23 +0000 (19:42 -0700)
commit6c3fbb1132d6dd0ac7b734f4323a269730748272
tree49e47af6d0fe976d4ea59af736c46f590c826334
parent4fd6663fd673228c43760b235ee55c649b799d47
ipv6: tcp: fix potential NULL deref in tcp_v6_send_reset()

syzbot found a crash in tcp_v6_send_reset() caused by my latest
change.

Problem is that if an skb has been queued to socket prequeue,
skb_dst(skb)->dev can not anymore point to the device.

Fortunately in this case the socket pointer is not NULL.

A similar issue has been fixed in commit b5a346c12c70 ("tcp: fix
more NULL deref after prequeue changes"), I should have known better.

Fixes: b75582f80200 ("ipv6: tcp: enable flowlabel reflection in some RST packets")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/tcp_ipv6.c