]> git.baikalelectronics.ru Git - kernel.git/commit
blk-mq: remove WARN_ON(!q->elevator) from blk_mq_sched_free_requests
authorMing Lei <ming.lei@redhat.com>
Tue, 11 Jun 2019 09:31:53 +0000 (17:31 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 13 Jun 2019 09:05:58 +0000 (03:05 -0600)
commit6bfa2e3f523544f8d3e71a4a0026fb4f8323131d
tree6ac0abaface94fbd7b0d60d7427b7351cfe245a4
parentfcd7e1f320bcfe33a2b0928417794bc9cf96ebd5
blk-mq: remove WARN_ON(!q->elevator) from blk_mq_sched_free_requests

blk_mq_sched_free_requests() may be called in failure path in which
q->elevator may not be setup yet, so remove WARN_ON(!q->elevator) from
blk_mq_sched_free_requests for avoiding the false positive.

This function is actually safe to call in case of !q->elevator because
hctx->sched_tags is checked.

Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Yi Zhang <yi.zhang@redhat.com>
Fixes: 4826a048bae2 ("block: free sched's request pool in blk_cleanup_queue")
Reported-by: syzbot+b9d0d56867048c7bcfde@syzkaller.appspotmail.com
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-sched.c