]> git.baikalelectronics.ru Git - kernel.git/commit
net/sched: cls_flower: Mandate mask when matching on flags
authorOr Gerlitz <ogerlitz@mellanox.com>
Thu, 22 Dec 2016 12:28:15 +0000 (14:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Dec 2016 16:59:56 +0000 (11:59 -0500)
commit6be12495b737704e6136ad8699899a368be9865a
tree98863f3ad1541e041d7a043f2f46005e45cd3fbd
parentec1c52c92dd348769b0e943daa94b95c22e0a59f
net/sched: cls_flower: Mandate mask when matching on flags

When matching on flags, we should require the user to provide the
mask and avoid using an all-ones mask. Not doing so causes matching
on flags provided w.o mask to hit on the value being unset for all
flags, which may not what the user wanted to happen.

Fixes: f7a9931a7120 ('net/sched: cls_flower: Add support for matching on flags')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reported-by: Paul Blakey <paulb@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_flower.c