]> git.baikalelectronics.ru Git - kernel.git/commit
cgroup-v1: Correct privileges check in release_agent writes
authorMichal Koutný <mkoutny@suse.com>
Thu, 17 Feb 2022 16:11:28 +0000 (17:11 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 22 Feb 2022 18:12:22 +0000 (08:12 -1000)
commit6b344a2a126484c9f1fa58e50bd1704b32b9cc90
tree00d3a89a6a4611e171e8122095861e9f77259ebf
parent478d2588329634fe2a60455bf540027560c04551
cgroup-v1: Correct privileges check in release_agent writes

The idea is to check: a) the owning user_ns of cgroup_ns, b)
capabilities in init_user_ns.

The commit 3ae097a730e6 ("cgroup-v1: Require capabilities to set
release_agent") got this wrong in the write handler of release_agent
since it checked user_ns of the opener (may be different from the owning
user_ns of cgroup_ns).
Secondly, to avoid possibly confused deputy, the capability of the
opener must be checked.

Fixes: 3ae097a730e6 ("cgroup-v1: Require capabilities to set release_agent")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/stable/20220216121142.GB30035@blackbody.suse.cz/
Signed-off-by: Michal Koutný <mkoutny@suse.com>
Reviewed-by: Masami Ichikawa(CIP) <masami.ichikawa@cybertrust.co.jp>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cgroup-v1.c