]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Use the same pte_encoding for ppgtt as for gtt
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 30 Jul 2013 18:04:37 +0000 (19:04 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 4 Aug 2013 19:29:57 +0000 (21:29 +0200)
commit6b03690952e1321a317a39214afa1ec733f2a9b1
tree205b99c6ade4e9efebf58c1a45cda4f74da663a2
parentd98d447ef9e7e972996e2c29448ceca5c59a814e
drm/i915: Use the same pte_encoding for ppgtt as for gtt

The PTE layouts are the same for both ppgtt and gtt, so we can simplify
the setup for ppgtt by copying the encoding function pointer from gtt.
This prevents bugs where we update one function pointer, but forget the
other.

For instance,

commit e10dc1276c1e3523a5b8cc93b284aebc51189ed1
Author: Ben Widawsky <ben@bwidawsk.net>
Date:   Thu Jul 4 11:02:06 2013 -0700

    drm/i915: Use eLLC/LLC by default when available

only extends the gtt to use eLLC/LLC cacheing and forgets to also update
the ppgtt function pointer.

v2: Actually mention the bug being fixed (Kenneth)

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_gtt.c