]> git.baikalelectronics.ru Git - kernel.git/commit
kconfig: Warn if choice default is not in choice
authorUlf Magnusson <ulfalizer@gmail.com>
Tue, 3 Oct 2017 23:25:46 +0000 (01:25 +0200)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 7 Dec 2017 14:45:51 +0000 (23:45 +0900)
commit6ad8a86f18e99034983790259442a10ff114c654
tree61a30648ff116674beb405316712d797ddb93a5f
parent801e5e26cc5ea4b1605798e8aa077abea774915f
kconfig: Warn if choice default is not in choice

This will catch mistakes like in the following real-world example, where
a "CONFIG_" prefix snuck in, making an undefined symbol the default:

choice
prompt "Compiler optimization level"
default CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE

config CC_OPTIMIZE_FOR_PERFORMANCE
...

config CC_OPTIMIZE_FOR_SIZE
...

endchoice

This now prints the following warning:

init/Kconfig:1036:warning: choice default symbol 'CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE' is not contained in the choice

Cases where the default symbol belongs to the wrong choice are also
detected.

(The mistake is harmless here: Since the default symbol is not visible,
the choice falls back on using the first visible symbol as the default,
which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.)

Discovered while playing around with Kconfiglib
(https://github.com/ulfalizer/Kconfiglib).

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kconfig/menu.c