]> git.baikalelectronics.ru Git - kernel.git/commit
[media] cx231xx: don't DMA to random addresses
authorDavid Dillow <dave@thedillows.org>
Mon, 18 Jun 2012 03:15:21 +0000 (00:15 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 6 Jul 2012 04:46:18 +0000 (01:46 -0300)
commit6ab6ea0f45e9acb35cf058ef0596107037056c70
tree12fe47bd42a669446246cb5f81eac71ac595d13e
parent5989021dcccf86e6812996fc31dd933d121a6b73
[media] cx231xx: don't DMA to random addresses

Commit 5288e8f6c14ad01dc401439a3b7ffcaf857b4a3b (cx231xx: use
URB_NO_TRANSFER_DMA_MAP) was intended to avoid mapping the DMA buffer
for URB twice. This works for the URBs allocated with usb_alloc_urb(),
as those are allocated from cohernent DMA pools, but the flag was also
added for the VBI and audio URBs, which have a manually allocated area.
This leaves the random trash in the structure after allocation as the
DMA address, corrupting memory and preventing VBI and audio from
working. Letting the USB core map the buffers solves the problem.

Signed-off-by: David Dillow <dave@thedillows.org>
Cc: Sri Deevi <srinivasa.deevi@conexant.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx231xx/cx231xx-audio.c
drivers/media/video/cx231xx/cx231xx-vbi.c