]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/pci: Unroll two pass loop when scanning bridges
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 10 Nov 2017 17:52:30 +0000 (19:52 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 19 Dec 2017 05:05:52 +0000 (23:05 -0600)
commit6a8ab8a439fb990af2403f9347a42c790091b55b
tree4ca8f71fa0dd8293cabaac39d378d0a91c558cc1
parent384ad02d13f6cc10d511319d5e6781dcbedde682
powerpc/pci: Unroll two pass loop when scanning bridges

The current scanning code is really hard to understand because it calls the
same function in a loop where pass value is changed without any comments
explaining it:

  for (pass = 0; pass < 2; pass++)
    for_each_pci_bridge(dev, bus)
      max = pci_scan_bridge(bus, dev, max, pass);

Unfamiliar reader cannot tell easily what is the purpose of this loop
without looking at internals of pci_scan_bridge().

In order to make this bit easier to understand, open-code the loop in
pci_scan_child_bus() and pci_hp_add_bridge() with added comments.

No functional changes intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
arch/powerpc/kernel/pci-hotplug.c