]> git.baikalelectronics.ru Git - kernel.git/commit
x86/stacktrace: Do not fail for ORC with regs on stack
authorJiri Slaby <jslaby@suse.cz>
Fri, 18 May 2018 06:47:11 +0000 (08:47 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 21 Jun 2018 14:34:56 +0000 (16:34 +0200)
commit69fa2ecabe7309fb42ed7f51cf29734a01bc8267
tree1a6ba2ef6278a56bea968a8a4ce96a80fd3487bb
parent8e22251f2752ae1c87dec632e2daa9c4f577d63a
x86/stacktrace: Do not fail for ORC with regs on stack

save_stack_trace_reliable now returns "non reliable" when there are
kernel pt_regs on stack. This means an interrupt or exception happened
somewhere down the route. It is a problem for the frame pointer
unwinder, because the frame might not have been set up yet when the irq
happened, so the unwinder might fail to unwind from the interrupted
function.

With ORC, this is not a problem, as ORC has out-of-band data. We can
find ORC data even for the IP in the interrupted function and always
unwind one level up reliably.

So lift the check to apply only when CONFIG_FRAME_POINTER=y is enabled.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/lkml/20180518064713.26440-4-jslaby@suse.cz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/stacktrace.c