]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "KVM: x86: always allow host-initiated writes to PMU MSRs"
authorSean Christopherson <seanjc@google.com>
Sat, 11 Jun 2022 00:57:52 +0000 (00:57 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 20 Jun 2022 15:49:46 +0000 (11:49 -0400)
commit698b3a6bad3d75e35c4891e86b1c919d63d2173a
tree5fa98bf0e6b77569ded69b8f528c3b2b44213e9f
parentf2bf284adf5d005c5f475e60072d575faaa5d59e
Revert "KVM: x86: always allow host-initiated writes to PMU MSRs"

Revert the hack to allow host-initiated accesses to all "PMU" MSRs,
as intel_is_valid_msr() returns true for _all_ MSRs, regardless of whether
or not it has a snowball's chance in hell of actually being a PMU MSR.

That mostly gets papered over by the actual get/set helpers only handling
MSRs that they knows about, except there's the minor detail that
kvm_pmu_{g,s}et_msr() eat reads and writes when the PMU is disabled.
I.e. KVM will happy allow reads and writes to _any_ MSR if the PMU is
disabled, either via module param or capability.

This reverts commit 217ed595e7c4e09dad53a65effdb18540904124d.

Fixes: 217ed595e7c4 ("KVM: x86: always allow host-initiated writes to PMU MSRs")
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220611005755.753273-5-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/pmu.c
arch/x86/kvm/pmu.h
arch/x86/kvm/svm/pmu.c
arch/x86/kvm/vmx/pmu_intel.c
arch/x86/kvm/x86.c