]> git.baikalelectronics.ru Git - kernel.git/commit
smsc911x: Ignore error return from device_get_phy_mode()
authorGuenter Roeck <linux@roeck-us.net>
Thu, 27 Aug 2015 03:27:05 +0000 (20:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Aug 2015 21:24:46 +0000 (14:24 -0700)
commit6952a724e59a9e09e60142ba3aa711743ae23caa
tree5fd75864e5ddf1503875896350810f0d9949b2fc
parentc3c21ebfb93202b1e13239f757f9b4588a78b682
smsc911x: Ignore error return from device_get_phy_mode()

Commit abf2c483d300 ("smsc911x: Fix crash seen if neither ACPI nor OF is
configured or used") introduces an error check for the return value from
device_get_phy_mode() and bails out if there is an error. Unfortunately,
there are configurations where no phy is configured. Those configurations
now fail.

To fix the problem, accept error returns from device_get_phy_mode(),
and use the return value from device_property_read_u32() to determine
if there is a suitable firmware interface to read the configuration.

Fixes: abf2c483d300 ("smsc911x: Fix crash seen if neither ACPI nor OF is configured or used")
Tested-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/smsc/smsc911x.c