]> git.baikalelectronics.ru Git - kernel.git/commit
net: fec: don't dump RX FIFO register when not available
authorFugang Duan <fugang.duan@nxp.com>
Mon, 15 Oct 2018 05:19:00 +0000 (05:19 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Oct 2018 05:52:18 +0000 (22:52 -0700)
commit69296e94ed16b9f31e9ded020df20e63e96b35d0
tree6eef69aee045c42bdc7c42933dc4f18369d6a4e8
parent0d90c584ffb40b677e19f9ad5fc72937c4dd75ca
net: fec: don't dump RX FIFO register when not available

Commit c08496634aad ("net: fec: add support of ethtool get_regs") introduce
ethool "--register-dump" interface to dump all FEC registers.

But not all silicon implementations of the Freescale FEC hardware module
have the FRBR (FIFO Receive Bound Register) and FRSR (FIFO Receive Start
Register) register, so we should not be trying to dump them on those that
don't.

To fix it we create a quirk flag, FEC_QUIRK_HAS_RFREG, and check it before
dump those RX FIFO registers.

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec.h
drivers/net/ethernet/freescale/fec_main.c