]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Make i945gm_vblank_work_func static
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 26 Jun 2019 22:42:12 +0000 (23:42 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 27 Jun 2019 13:08:50 +0000 (14:08 +0100)
commit69256915fe4159ebe351908ac4bef5078db2f6ef
tree279d16406b1141ff4700ae4e61cf2c7b5bdb4b12
parentd31c56083e56fc8097b0131c50e689b2dbfd606c
drm/i915: Make i945gm_vblank_work_func static

drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol 'i945gm_vblank_work_func' was not declared. Should it be static?
  CC [M]  drivers/gpu/drm/i915/i915_irq.o
drivers/gpu/drm/i915/i915_irq.c:3382:6: error: no previous prototype for ‘i945gm_vblank_work_func’ [-Werror=missing-prototypes]
 void i945gm_vblank_work_func(struct work_struct *work)

Jani wrote the idential patch, so for posterity:

The static keyword was apparently accidentally removed in commit
337ce80bc209 ("drm/i915: Switch to per-crtc vblank vfuncs"), leading to
sparse warning:

drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol
'i945gm_vblank_work_func' was not declared. Should it be static?

Make the function static again.

Meanwhile, the 0-day kbuilder also spotted the mistake.

Fixes: 337ce80bc209 ("drm/i915: Switch to per-crtc vblank vfuncs")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190626224212.10141-1-chris@chris-wilson.co.uk
Link: https://patchwork.freedesktop.org/patch/msgid/20190627091914.30795-1-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_irq.c