]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/isdn: correct use of ! and &
authorJulia Lawall <julia@diku.dk>
Tue, 4 Mar 2008 22:29:18 +0000 (14:29 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 5 Mar 2008 00:35:16 +0000 (16:35 -0800)
commit68cf82f080aff319aef6a64572a7f1cf74cbaac4
tree728da1949f0a401c48f1bcf81cb4f50ca7a26384
parent67ee1318511e9176ca8fc39cc0a4f92dbca26b40
drivers/isdn: correct use of ! and &

In commit fbb1ccd43b0dfa2ef851295f09c104022e4e2c88 ("wmi: (!x & y)
strikes again"), a bug was fixed that involved converting !x & y to !(x
& y).  The code below shows the same pattern, and thus should perhaps be
fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/isdn/i4l/isdn_ttyfax.c
drivers/isdn/isdnloop/isdnloop.c