]> git.baikalelectronics.ru Git - kernel.git/commit
locking/rwsem: Check for active lock before bailing on spinning
authorDavidlohr Bueso <dave@stgolabs.net>
Fri, 30 Jan 2015 09:14:27 +0000 (01:14 -0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 18 Feb 2015 15:57:18 +0000 (16:57 +0100)
commit68bafb3001417b19911c3a7c972959825ccbb45a
tree9d066f2915a65fa9180fd7c0d69b5c3991eb1d71
parentaee1112a65432577864addc901003a758d7ba3f0
locking/rwsem: Check for active lock before bailing on spinning

5017f27e730 ("locking/rwsem: Allow conservative optimistic
spinning when readers have lock") forced the default for
optimistic spinning to be disabled if the lock owner was
nil, which makes much sense for readers. However, while
it is not our priority, we can make some optimizations
for write-mostly workloads. We can bail the spinning step
and still be conservative if there are any active tasks,
otherwise there's really no reason not to spin, as the
semaphore is most likely unlocked.

This patch recovers most of a Unixbench 'execl' benchmark
throughput by sleeping less and making better average system
usage:

  before:
  CPU     %user     %nice   %system   %iowait    %steal     %idle
  all      0.60      0.00      8.02      0.00      0.00     91.38

  after:
  CPU     %user     %nice   %system   %iowait    %steal     %idle
  all      1.22      0.00     70.18      0.00      0.00     28.60

Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Jason Low <jason.low2@hp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michel Lespinasse <walken@google.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Link: http://lkml.kernel.org/r/1422609267-15102-6-git-send-email-dave@stgolabs.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/rwsem-xadd.c