]> git.baikalelectronics.ru Git - kernel.git/commit
io_uring: ensure we clear io_kiocb->result before each issue
authorJens Axboe <axboe@kernel.dk>
Wed, 30 Oct 2019 19:53:09 +0000 (13:53 -0600)
committerJens Axboe <axboe@kernel.dk>
Wed, 30 Oct 2019 20:45:22 +0000 (14:45 -0600)
commit6873e0bd6a9cb14ecfadd89d9ed9698ff1761902
tree6d90ad4c5a4ab0213fdbc8d7e8c3b8d22cfa98db
parentd848074b2f1eb11a38691285f7366bce83087014
io_uring: ensure we clear io_kiocb->result before each issue

We use io_kiocb->result == -EAGAIN as a way to know if we need to
re-submit a polled request, as -EAGAIN reporting happens out-of-line
for IO submission failures. This field is cleared when we originally
allocate the request, but it isn't reset when we retry the submission
from async context. This can cause issues where we think something
needs a re-issue, but we're really just reading stale data.

Reset ->result whenever we re-prep a request for polled submission.

Cc: stable@vger.kernel.org
Fixes: 9e645e1105ca ("io_uring: add support for sqe links")
Reported-by: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c