]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/ide/cy82c693.c: Add missing pci_dev_put
authorJulia Lawall <julia@diku.dk>
Thu, 4 Aug 2011 08:30:34 +0000 (01:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 4 Aug 2011 08:30:34 +0000 (01:30 -0700)
commit686f23f4f79f1e68188ac905705246c2a020f8cb
treeb6c4c8414f93f9feb4142f68ab02c7bfb1f284f6
parentdee33ee9496601fb052c423f3aa79036a42a97d0
drivers/ide/cy82c693.c: Add missing pci_dev_put

Pci_get_slot calls pci_dev_get, so pci_dev_put is needed before leaving the
function in the case where pci_get_slot is locally used.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
local idexpression x;
expression e;
@@

*x = pci_get_slot(...)
... when != true x == NULL
    when != pci_dev_put(x)
    when != e = x
    when != if (x != NULL) {<+... pci_dev_put(x); ...+>}
*return ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/cy82c693.c