]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Remove unnecessary self assignment
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 20 Sep 2018 22:17:06 +0000 (15:17 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Oct 2018 22:19:46 +0000 (18:19 -0400)
commit67bc90cdd9dc211e060a96174aacb654abf88a5e
treed416d1ac90793150ec6e37a98dc897590c524146
parentfcd6dbd40feaf7c76dbfdc38efe368f1b7b39270
scsi: qla2xxx: Remove unnecessary self assignment

Clang warns when a variable is assigned to itself.

drivers/scsi/qla2xxx/qla_mbx.c:1514:4: warning: explicitly assigning
value of variable of type 'uint64_t' (aka 'unsigned long long') to
itself [-Wself-assign]
        l = l;
        ~ ^ ~
1 warning generated.

This construct is usually used to avoid unused variable warnings, which
I assume is the case here. -Wunused-parameter is hidden behind -Wextra
with GCC 4.6, which is the minimum version to compile the kernel as of
commit 46ed35d9f3fa ("Raise the minimum required gcc version to 4.6").
Just remove this line to silence Clang.

Link: https://github.com/ClangBuiltLinux/linux/issues/83
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_mbx.c