]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Thu, 12 Mar 2020 19:48:50 +0000 (14:48 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 13 Mar 2020 15:44:49 +0000 (15:44 +0000)
commit67761eac51cce0abfa7c93cdd6140973616872ae
tree2746ec33670c4b336ffe2e29b7a3954645e02a6c
parent30a19b01f36af3bec3ffc68ba0d07e3435b7b170
ASoC: Intel: boards: drop reverse deps for SND_HDA_CODEC_HDMI

Having a reverse dependency to a config that has its own additional
dependencies, is generally not recommended. And this applies to
select statements for SND_HDA_CODEC_HDMI, e.g. the case where SND_HDA
and SND_SOC_SOF_HDA are built as modules, but the machine driver is
built-in, leading to compile errors (reported as
i386-randconfig-e003-20200206).

Give up on trying to define different dependencies based on SOF/SST
selection, and simply add a "depends on" for SND_HDA_CODEC_HDMI. This
fixes the issue with randconfigs. Only downside is that SND_HDA_CODEC_HDMI
may be built unnecessarily in some cases, but this seems like the lesser
evil.

Fixes: b24d2da ('ASoC: Intel: boards: fix incorrect HDMI Kconfig dependency')
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200312194859.4051-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/Kconfig