]> git.baikalelectronics.ru Git - kernel.git/commit
[netdrvr starfire] fix highmem and broken firmware issues
authorIon Badulescu <ionut@badula.org>
Tue, 4 Oct 2005 02:31:36 +0000 (22:31 -0400)
committerJeff Garzik <jgarzik@pobox.com>
Tue, 4 Oct 2005 02:31:36 +0000 (22:31 -0400)
commit673dca0b29a9475ae51fd9dd9576639cf4fc1879
tree14eccea7e68aed055aff5847b8dfdb32500aece0
parent0c6ec1e65daaec26be0657b90dbe42c58b9dfae1
[netdrvr starfire] fix highmem and broken firmware issues

Unfortunately, [your patch] might address the crash but doesn't address
the real problem. It turns out that the problem is one of padding
(the firmware cksum engine works only on 32-bit chunks, yuck), so
the special casing for length == 1 wasn't sufficient anyway.

This patch addresses the issue, as well the other issue of i386 +
CONFIG_HIGHMEM being broken. It is pretty much the same workaround
that Adaptec themselves used in their Windows driver. I have yet to
check if it fixes the problem when the skb is non-linear, but this
patch _will_ solve the problem for 99% of the users out there (those
not using sendfile).

Signed-off-by: Ion Badulescu <ionut@badula.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/net/starfire.c