]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: rawnand: orion: Do not force a particular software ECC engine
authorMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 3 Dec 2020 19:03:36 +0000 (20:03 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Fri, 11 Dec 2020 19:09:58 +0000 (20:09 +0100)
commit66a55b8542aab624faac01801eb3cec36d279be5
tree2b2d370218fd83ba59e6ac058110e283e42b193c
parentd950c61c3323558e05d5e5789a3f88522962e58b
mtd: rawnand: orion: Do not force a particular software ECC engine

Originally, commit 86503c2fe61f ("mtd: rawnand: Use the ECC framework
user input parsing bits") kind of broke the logic around the
initialization of several ECC engines.

Unfortunately, the fix (which indeed moved the ECC initialization to
the right place) did not take into account the fact that a different
ECC algorithm could have been used thanks to a DT property,
considering the "Hamming" algorithm entry a configuration while it was
only a default.

Add the necessary logic to be sure Hamming keeps being only a default.

Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Fixes: e42c021e7131 ("mtd: rawnand: orion: Move the ECC initialization to ->attach_chip()")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Tested-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/linux-mtd/20201203190340.15522-6-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/orion_nand.c