]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amdgpu: Fix undue fallthroughs in golden registers initialization
authorJean Delvare <jdelvare@suse.de>
Sun, 30 Jul 2017 08:18:25 +0000 (10:18 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 2 Aug 2017 18:29:42 +0000 (14:29 -0400)
commit66a4fc98bcfd1c9fa7ad99a16814a7ba9c5652b2
tree3b89f0cf1ba1c94dc0441fa3cdc36cfb7310e105
parent132ffd088a755e9d297207510564b290f21ceb4b
drm/amdgpu: Fix undue fallthroughs in golden registers initialization

As I was staring at the si_init_golden_registers code, I noticed that
the Pitcairn initialization silently falls through the Cape Verde
initialization, and the Oland initialization falls through the Hainan
initialization. However there is no comment stating that this is
intentional, and the radeon driver doesn't have any such fallthrough,
so I suspect this is not supposed to happen.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: dcbd37c162f4 ("drm/amdgpu: add si implementation v10")
Cc: Ken Wang <Qingqing.Wang@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Marek Olšák" <maraeo@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Flora Cui <Flora.Cui@amd.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/si.c