]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a501172) | patch
ethtool: linkinfo: remove an unnecessary NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 5 Jun 2020 11:04:13 +0000 (14:04 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Jun 2020 20:10:02 +0000 (13:10 -0700)
commit6637b2ba449f1324c04ebe81ee08b7b12b3d1340
tree1ec860fb6ae58be98d009b9a5975396b120b6b24tree | snapshot
parenta50117253066e480c146f8f18501f995a6ff3a6bcommit | diff
ethtool: linkinfo: remove an unnecessary NULL check

This code generates a Smatch warning:

    net/ethtool/linkinfo.c:143 ethnl_set_linkinfo()
    warn: variable dereferenced before check 'info' (see line 119)

Fortunately, the "info" pointer is never NULL so the check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/linkinfo.c diff | blob | history
Linux Kernel Source Tree.