]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY
authorSebastian Frias <sf84@laposte.net>
Wed, 23 Mar 2016 10:49:09 +0000 (11:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Mar 2016 17:39:25 +0000 (13:39 -0400)
commit65c1025d8036d4a0011b366feee6495756b478f6
tree1c81642169cd379ad3362620db7eff2fc67188e0
parentd4243dc72297522b75ff8da8aa28f4242c00c148
net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

This removes the dependency on GPIOLIB for non faulty PHYs.

Indeed, without this patch, if GPIOLIB is not selected
devm_gpiod_get_optional() will return -ENOSYS and the driver probe
call will fail, regardless of the actual PHY hardware.

Out of the 3 PHYs supported by this driver (AT8030, AT8031, AT8035),
only AT8030 presents the issues that commit d3a69f66d297 ("net: phy:
at803x: Add support for hardware reset") attempts to work-around by
using a 'reset' GPIO line.

Hence, only AT8030 should depend on GPIOLIB operating properly.

Fixes: d3a69f66d297 ("net: phy: at803x: Add support for hardware reset")
Signed-off-by: Sebastian Frias <sf84@laposte.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/at803x.c