]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: sctp_epaddr_lookup_transport should be protected by rcu_read_lock
authorXin Long <lucien.xin@gmail.com>
Thu, 15 Dec 2016 15:00:55 +0000 (23:00 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Dec 2016 16:43:23 +0000 (11:43 -0500)
commit657b08b048527ee94161016c180e692ea85d96a3
tree1f33fd5c6275bae24cd7f03b8f5a6bb8766e6c6f
parent1c7278b62958e960b83e4899f619a59f6b4f960b
sctp: sctp_epaddr_lookup_transport should be protected by rcu_read_lock

Since commit eb38820ca3d8 ("sctp: use new rhlist interface on sctp transport
rhashtable"), sctp has changed to use rhlist_lookup to look up transport, but
rhlist_lookup doesn't call rcu_read_lock inside, unlike rhashtable_lookup_fast.

It is called in sctp_epaddr_lookup_transport and sctp_addrs_lookup_transport.
sctp_addrs_lookup_transport is always in the protection of rcu_read_lock(),
as __sctp_lookup_association is called in rx path or sctp_lookup_association
which are in the protection of rcu_read_lock() already.

But sctp_epaddr_lookup_transport is called by sctp_endpoint_lookup_assoc, it
doesn't call rcu_read_lock, which may cause "suspicious rcu_dereference_check
usage' in __rhashtable_lookup.

This patch is to fix it by adding rcu_read_lock in sctp_endpoint_lookup_assoc
before calling sctp_epaddr_lookup_transport.

Fixes: eb38820ca3d8 ("sctp: use new rhlist interface on sctp transport rhashtable")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/endpointola.c