]> git.baikalelectronics.ru Git - kernel.git/commit
nvme-loop: fix kernel oops in case of unhandled command
authorMing Lei <ming.lei@redhat.com>
Thu, 12 Apr 2018 15:16:04 +0000 (09:16 -0600)
committerJens Axboe <axboe@kernel.dk>
Thu, 12 Apr 2018 15:58:27 +0000 (09:58 -0600)
commit651532c111b4333940ba8c7b2237caa4eb6c85d0
tree138e77ac276f5484e2c50ce30fc7449ca65348f8
parent258c2f5d90b7e0996b0aac5836b4b73cd0d4528b
nvme-loop: fix kernel oops in case of unhandled command

When nvmet_req_init() fails, __nvmet_req_complete() is called
to handle the target request via .queue_response(), so
nvme_loop_queue_response() shouldn't be called again for
handling the failure.

This patch fixes this case by the following way:

- move blk_mq_start_request() before nvmet_req_init(), so
nvme_loop_queue_response() may work well to complete this
host request

- don't call nvme_cleanup_cmd() which is done in nvme_loop_complete_rq()

- don't call nvme_loop_queue_response() which is done via
.queue_response()

Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[trimmed changelog]
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/target/loop.c