]> git.baikalelectronics.ru Git - kernel.git/commit
selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion
authorPaolo Pisati <paolo.pisati@canonical.com>
Tue, 14 Jul 2020 15:40:55 +0000 (17:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Jul 2020 22:06:12 +0000 (15:06 -0700)
commit651149f60376758a4759f761767965040f9e4464
tree5406517f7d05df0b6d0a2bb847f52d2763b001e9
parentff021f22ea8f1388ced048243c6e06ca5cfbd62a
selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion

During setup():
...
        for ns in h0 r1 h1 h2 h3
        do
                create_ns ${ns}
        done
...

while in cleanup():
...
        for n in h1 r1 h2 h3 h4
        do
                ip netns del ${n} 2>/dev/null
        done
...

and after removing the stderr redirection in cleanup():

$ sudo ./fib_nexthop_multiprefix.sh
...
TEST: IPv4: host 0 to host 3, mtu 1400                              [ OK ]
TEST: IPv6: host 0 to host 3, mtu 1400                              [ OK ]
Cannot remove namespace file "/run/netns/h4": No such file or directory
$ echo $?
1

and a non-zero return code, make kselftests fail (even if the test
itself is fine):

...
not ok 34 selftests: net: fib_nexthop_multiprefix.sh # exit=1
...

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/fib_nexthop_multiprefix.sh