]> git.baikalelectronics.ru Git - kernel.git/commit
rtnetlink: Warn when interface's information won't fit in our packet
authorDavid Gibson <david@gibson.dropbear.id.au>
Thu, 24 Apr 2014 00:22:35 +0000 (10:22 +1000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Apr 2014 17:52:54 +0000 (13:52 -0400)
commit64eba3a6a9faaff7ce5f9099b0eb3d439682b9f3
treefdf9ac5d381071d750adb9cb81e406a2b16fd58f
parentb4ebb08a4269283e6681b9ce2c019eae297e232e
rtnetlink: Warn when interface's information won't fit in our packet

Without IFLA_EXT_MASK specified, the information reported for a single
interface in response to RTM_GETLINK is expected to fit within a netlink
packet of NLMSG_GOODSIZE.

If it doesn't, however, things will go badly wrong,  When listing all
interfaces, netlink_dump() will incorrectly treat -EMSGSIZE on the first
message in a packet as the end of the listing and omit information for
that interface and all subsequent ones.  This can cause getifaddrs(3) to
enter an infinite loop.

This patch won't fix the problem, but it will WARN_ON() making it easier to
track down what's going wrong.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c