]> git.baikalelectronics.ru Git - kernel.git/commit
HID: mcp2221: prevent a buffer overflow in mcp_smbus_write()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Mon, 20 Jun 2022 16:28:24 +0000 (09:28 -0700)
committerJiri Kosina <jkosina@suse.cz>
Thu, 21 Jul 2022 09:54:40 +0000 (11:54 +0200)
commit6499544ac8c393268cd91bf58ac5041074485366
tree0e190aa9d5101a22cef662e9964b9492b686d4a3
parent73ac98a10f2a2fcc1a2d96a9c08b8422cadfc620
HID: mcp2221: prevent a buffer overflow in mcp_smbus_write()

Smatch Warning:
drivers/hid/hid-mcp2221.c:388 mcp_smbus_write() error: __memcpy()
'&mcp->txbuf[5]' too small (59 vs 255)
drivers/hid/hid-mcp2221.c:388 mcp_smbus_write() error: __memcpy() 'buf'
too small (34 vs 255)

The 'len' variable can take a value between 0-255 as it can come from
data->block[0] and it is user data. So add an bound check to prevent a
buffer overflow in memcpy().

Fixes: 2b1bbc22f0f8 ("HID: mcp2221: add usb to i2c-smbus host bridge")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-mcp2221.c