]> git.baikalelectronics.ru Git - kernel.git/commit
iscsi-target: remove dead code in iscsi_check_valuelist_for_support
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 17 May 2012 07:08:14 +0000 (10:08 +0300)
committerNicholas Bellinger <nab@linux-iscsi.org>
Thu, 17 May 2012 19:04:53 +0000 (12:04 -0700)
commit640aaf74965c0959e90a5ce2bc5e6900bdc4d646
treed653bbb80bf2b3144e05223413f6792c87fc3d28
parent824ff4259ec49922546837c80dff4a6fd9729548
iscsi-target: remove dead code in iscsi_check_valuelist_for_support

Neither "acceptor_values" nor "proposer_values" can be NULL here when
scanning the value lists for incoming iSCSI login parameters such as
HeaderDigest=CRC32C,None.

Smatch complains because we are not allowed to pass NULL pointers to
strchr().  Also I removed a second later check for "!acceptor_values"
because it gets checked on the next line in the do while condition.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_parameters.c