]> git.baikalelectronics.ru Git - kernel.git/commit
net: mhi: Fix unexpected queue wake
authorLoic Poulain <loic.poulain@linaro.org>
Thu, 10 Dec 2020 11:25:07 +0000 (12:25 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Dec 2020 01:25:56 +0000 (17:25 -0800)
commit63c2189275d67f5adf98e0e0120e906806d0199e
treedb1a92d6bec64bd45a6e17c843b6ae9e1303dfd7
parentb797e14f2a2797c3d67d9fe0e26049cca7017ba9
net: mhi: Fix unexpected queue wake

This patch checks that MHI queue is not full before waking up the net
queue. This fix sporadic MHI queueing issues in xmit. Indeed xmit and
its symmetric complete callback (ul_callback) can run concurently, it
is then not safe to unconditionnaly waking the queue in the callback
without checking queue fullness.

Fixes: 9e86f6b15cf5 ("net: Add mhi-net driver")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Link: https://lore.kernel.org/r/1607599507-5879-1-git-send-email-loic.poulain@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/mhi_net.c