]> git.baikalelectronics.ru Git - kernel.git/commit
mfd: tps65218: Reorder tps65218_regulator_id enum
authorDave Gerlach <d-gerlach@ti.com>
Fri, 16 Feb 2018 04:17:05 +0000 (22:17 -0600)
committerLee Jones <lee.jones@linaro.org>
Wed, 16 May 2018 08:21:48 +0000 (09:21 +0100)
commit625c9fb626508cb099410b7e4ade54f8a76854b9
tree104ffc9b88537d6aca7df17898e2e49e2b85894c
parent427cf1d7dc2e0526e57b563b4de892ea5771463c
mfd: tps65218: Reorder tps65218_regulator_id enum

Commit 25de12e925ac ("regulator: tps65218: Remove all the compatibles")
changes the probe function of drivers/regulator/tps65218-regulator.c so
that it iterates through all available regulators and assumes that the
regulator IDs are sequential and match the order present in the enum
tps65218_regulator_id. However, for some reason the much older commit
8c207ee2e6c6 ("regulator: tps65218: add support for LS3 current
regulator") updated all arrays with LS3 at the end but added it second
to last for the enum.

Because of this long standing mismatch in order between the
tps65218_regulator_id enum and the regulator_desc array in the tps65218
regulator driver, the new probe function causes the strobe values to be
associated with the wrong regulator ID. This causes LDO1 to fail to
suspend in tps65218_pmic_set_suspend_disable due to not having anything
probes for its strobe value. Fix the order in the enum so the probe
function works as the update intended.

Fixes: 25de12e925ac ("regulator: tps65218: Remove all the compatibles")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
include/linux/mfd/tps65218.h