]> git.baikalelectronics.ru Git - kernel.git/commit
xfrm_user: validate XFRM_MSG_NEWAE XFRMA_REPLAY_ESN_VAL replay_window
authorAndy Whitcroft <apw@canonical.com>
Wed, 22 Mar 2017 07:29:31 +0000 (07:29 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 29 Mar 2017 15:40:06 +0000 (08:40 -0700)
commit61fcf0b268e48c7f6b3291f9b72c38e0b1e1e8f1
tree094a72733ec4b13d8a85f11eb1f32e1b1888fdf3
parent67f87e4dfdffd65cc4e15e42a43e6b1c9aa4b34c
xfrm_user: validate XFRM_MSG_NEWAE XFRMA_REPLAY_ESN_VAL replay_window

When a new xfrm state is created during an XFRM_MSG_NEWSA call we
validate the user supplied replay_esn to ensure that the size is valid
and to ensure that the replay_window size is within the allocated
buffer.  However later it is possible to update this replay_esn via a
XFRM_MSG_NEWAE call.  There we again validate the size of the supplied
buffer matches the existing state and if so inject the contents.  We do
not at this point check that the replay_window is within the allocated
memory.  This leads to out-of-bounds reads and writes triggered by
netlink packets.  This leads to memory corruption and the potential for
priviledge escalation.

We already attempt to validate the incoming replay information in
xfrm_new_ae() via xfrm_replay_verify_len().  This confirms that the user
is not trying to change the size of the replay state buffer which
includes the replay_esn.  It however does not check the replay_window
remains within that buffer.  Add validation of the contained
replay_window.

CVE-2017-7184
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/xfrm/xfrm_user.c