]> git.baikalelectronics.ru Git - kernel.git/commit
Makefile: Fix lying comment re. silentoldconfig
authorUlf Magnusson <ulfalizer@gmail.com>
Tue, 13 Feb 2018 07:58:20 +0000 (08:58 +0100)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 1 Mar 2018 15:26:46 +0000 (00:26 +0900)
commit616e70311844681ddc540f1915929fb0431c16da
tree47866d17e3ce3a06446d29979eb081da8dc23e74
parent0a971331c84ae05259efa3c31ed9df6504e62eb8
Makefile: Fix lying comment re. silentoldconfig

The comment above the silentoldconfig invocation is outdated.
'make oldconfig' updates just .config and doesn't touch the
include/config/ tree.

This came up in https://lkml.org/lkml/2018/2/12/415.

While fixing the comment, make it more informative by explaining the
purpose of the unfortunately named silentoldconfig.

I can't make sense of the comment re. auto.conf.cmd and a cleaned tree.
include/config/auto.conf and include/config/auto.conf.cmd are both
created simultaneously by silentoldconfig (in
scripts/kconfig/confdata.c, by conf_write_autoconf()), and nothing seems
to remove auto.conf.cmd that wouldn't remove auto.conf. Remove that part
of the comment rather than blindly copying it. It might be a leftover
from an older way of doing things.

The include/config/auto.conf.cmd prerequisite might be there to ensure
that silentoldconfig gets rerun if conf_write_autoconf() fails between
writing out auto.conf.cmd and auto.conf (a comment in the function
indicates that auto.conf is deliberately written out last to mark
completion of the operation). It seems the Makefile dependency between
include/config/auto.conf and .config would already take care of that
though, since include/config/auto.conf would still be out of date re.
.config if the operation fails.

Cop out and leave the prerequisite in for now.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Makefile