]> git.baikalelectronics.ru Git - kernel.git/commit
s390/mm: fix refcount usage for 4K pgste
authorEric Farman <farman@linux.ibm.com>
Fri, 29 Jun 2018 17:54:01 +0000 (19:54 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Mon, 2 Jul 2018 09:25:39 +0000 (11:25 +0200)
commit610c077a631686641ddb3a267dc7ec31606628bf
treeb9fa7cdab4e365e8de3253f91bff6727a10c7578
parent91d403d5862357049aa7798d4dcbcb480dea6255
s390/mm: fix refcount usage for 4K pgste

s390 no longer uses the _mapcount field in struct page to identify
the page table format being used. While the code was diligent in handling
the different mappings, it neglected to turn "off" the map bits when
alloc_pgste was being used. This resulted in bits remaining "on" in the
_refcount field, and thus an artifically huge "in use" count that prevents
the pages from actually being released by __free_page.

There's opportunity for improvement in the "1 vs 3" vs "1U vs 3U" vs
"0x1 vs 0x11" etc. variations for all these calls, I am just keeping
things simple compared to neighboring code.

Fixes: 4deeaa2f9584 ("s390: use _refcount for pgtables")
Reported-by: Halil Pasic <pasic@linux.ibm.com>
Bisected-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/mm/pgalloc.c