]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6
authorJulien Grall <julien.grall@citrix.com>
Tue, 7 Jul 2015 14:55:21 +0000 (15:55 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 8 Jul 2015 09:02:16 +0000 (11:02 +0200)
commit60598f2f4694cc2d3a0063e693fbd5b5eaf27fac
treebab4f3db9039c9d9db5b9b2e31eef70c8719104a
parent2178b7e9eefe3f7dc89e1f0d43276271cce03490
netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

The commit 6a3dde6914924b704d74311f6a3b16ad73b136ee "netfilter: bridge:
forward IPv6 fragmented packets" introduced a new function
br_validate_ipv6 which take a reference on the inet6 device. Although,
the reference is not released at the end.

This will result to the impossibility to destroy any netdevice using
ipv6 and bridge.

It's possible to directly retrieve the inet6 device without taking a
reference as all netfilter hooks are protected by rcu_read_lock via
nf_hook_slow.

Spotted while trying to destroy a Xen guest on the upstream Linux:
"unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"

Signed-off-by: Julien Grall <julien.grall@citrix.com>
Cc: Bernhard Thaler <bernhard.thaler@wvnet.at>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: fw@strlen.de
Cc: ian.campbell@citrix.com
Cc: wei.liu2@citrix.com
Cc: Bob Liu <bob.liu@oracle.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/bridge/br_netfilter_ipv6.c