]> git.baikalelectronics.ru Git - kernel.git/commit
ice: Ignore error message when setting same promiscuous mode
authorBenjamin Mikailenko <benjamin.mikailenko@intel.com>
Fri, 12 Aug 2022 13:25:50 +0000 (15:25 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 17 Aug 2022 16:30:44 +0000 (09:30 -0700)
commit60259330991e0f4db69bc0df6966e2c4b403e82b
treea592cf526dc021c9e4e2c213249e698618512648
parentb12cefb2a36b5d4ae1759d4d9402be1f47ad57e6
ice: Ignore error message when setting same promiscuous mode

Commit 4814b6389321 ("ice: Fix broken IFF_ALLMULTI handling")
introduced new checks when setting/clearing promiscuous mode. But if the
requested promiscuous mode setting already exists, an -EEXIST error
message would be printed. This is incorrect because promiscuous mode is
either on/off and shouldn't print an error when the requested
configuration is already set.

This can happen when removing a bridge with two bonded interfaces and
promiscuous most isn't fully cleared from VLAN VSI in hardware.

Fix this by ignoring cases where requested promiscuous mode exists.

Fixes: 4814b6389321 ("ice: Fix broken IFF_ALLMULTI handling")
Signed-off-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
Link: https://lore.kernel.org/all/CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_fltr.c