]> git.baikalelectronics.ru Git - kernel.git/commit
tun: avoid unnecessary READ_ONCE in tun_net_xmit
authorWillem de Bruijn <willemb@google.com>
Wed, 6 Dec 2017 03:11:17 +0000 (22:11 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 Dec 2017 20:09:13 +0000 (15:09 -0500)
commit60180d5cceb08741d9057e836ce36daa54c17a87
tree3e7b0e2a412e37f7a5a4e9000c496de3ecb9a633
parent008b74118138ba9f41140b8e960f87e0a478668f
tun: avoid unnecessary READ_ONCE in tun_net_xmit

The statement no longer serves a purpose.

Commit cf73b43f7028 ("tuntap: Fix for a race in accessing numqueues")
added the ACCESS_ONCE to avoid a race condition with skb_queue_len.

Commit 439746289763 ("tuntap: remove unnecessary sk_receive_queue
length check during xmit") removed the affected skb_queue_len check.

Commit c21d7da761b0 ("tun: add eBPF based queue selection method")
split the function, reading the field a second time in the callee.
The temp variable is now only read once, so just remove it.

Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c