]> git.baikalelectronics.ru Git - kernel.git/commit
block: Remove the synchronize_rcu() call from __blk_mq_update_nr_hw_queues()
authorBart Van Assche <bvanassche@acm.org>
Fri, 25 Oct 2019 16:50:08 +0000 (09:50 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 25 Oct 2019 20:12:17 +0000 (14:12 -0600)
commit5f8ca7519ff71ad6598a64b7d66e7d276e2f9d88
tree58b254153ffb257f235cedb67f1920ec0d8e4fd9
parent6ef604855ccbed370f7f2a9de3538bf52e5a9827
block: Remove the synchronize_rcu() call from __blk_mq_update_nr_hw_queues()

Since the blk_mq_{,un}freeze_queue() calls in __blk_mq_update_nr_hw_queues()
already serialize __blk_mq_update_nr_hw_queues() against
blk_mq_queue_tag_busy_iter(), the synchronize_rcu() call in
__blk_mq_update_nr_hw_queues() is not necessary. Hence remove it.

Note: the synchronize_rcu() call in __blk_mq_update_nr_hw_queues() was
introduced by commit 5ef4dfb8e31c ("blk-mq: sync the update nr_hw_queues with
blk_mq_queue_tag_busy_iter"). Commit 6d8a59c4a3a6 ("blk-mq: Allow blocking
queue tag iter callbacks") removed the rcu_read_{,un}lock() calls that
correspond to the synchronize_rcu() call in __blk_mq_update_nr_hw_queues().

Reviewed-by: Ming Lei <ming.lei@redhat.com>
Cc: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c