]> git.baikalelectronics.ru Git - kernel.git/commit
can: bcm: fix infoleak in struct bcm_msg_head
authorNorbert Slusarek <nslusarek@gmx.net>
Sat, 12 Jun 2021 20:18:54 +0000 (22:18 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 16 Jun 2021 10:52:18 +0000 (12:52 +0200)
commit5e87ddbe3942e27e939bdc02deb8579b0cbd8ecc
tree65e6bfa6d5758582377e6be43fb1d799372f6571
parent8d0caedb759683041d9db82069937525999ada53
can: bcm: fix infoleak in struct bcm_msg_head

On 64-bit systems, struct bcm_msg_head has an added padding of 4 bytes between
struct members count and ival1. Even though all struct members are initialized,
the 4-byte hole will contain data from the kernel stack. This patch zeroes out
struct bcm_msg_head before usage, preventing infoleaks to userspace.

Fixes: ffd980f976e7 ("[CAN]: Add broadcast manager (bcm) protocol")
Link: https://lore.kernel.org/r/trinity-7c1b2e82-e34f-4885-8060-2cd7a13769ce-1623532166177@3c-app-gmx-bs52
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Norbert Slusarek <nslusarek@gmx.net>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/bcm.c